Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding in example for GKE-Autopilot, closes #19 #270

Merged
merged 3 commits into from
Dec 23, 2024
Merged

Conversation

rshade
Copy link
Contributor

@rshade rshade commented Dec 20, 2024

No description provided.

Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@rshade rshade force-pushed the auto-pilot-example branch from 25528ae to 9196ac9 Compare December 20, 2024 19:49
@rshade rshade requested a review from blampe December 23, 2024 20:18
@@ -118,7 +118,7 @@ type CertManagerGlobalPodSecurityPolicy struct {

type CertManagerGlobalLeaderElection struct {
// Override the namespace used to store the ConfigMap for leader election.
Namespace *string `pulumi:"namespace"`
Namespace pulumi.StringPtrInput `pulumi:"namespace"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with how this project was set up -- do you know if this code is generated or was it written by hand?

If it's generated we probably want to create an issue somewhere (here? https://github.com/pulumi/pulumi-go-helmbase) to address the underlying bug.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe its hand coded, I think @joeduffy might be the only one that knows the real answer though.

@rshade rshade merged commit 88ade76 into master Dec 23, 2024
17 checks passed
@rshade rshade deleted the auto-pilot-example branch December 23, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants